Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing aws_ecr_lifecycle_policy tagPatternList change detection #35231

Merged
1 commit merged into from
Mar 29, 2024
Merged

fix: Add missing aws_ecr_lifecycle_policy tagPatternList change detection #35231

1 commit merged into from
Mar 29, 2024

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Jan 10, 2024 •
edited
Loading

Description

This PR is to fix change detection issues (specifically the lack of it) with the tagPatternList attribute in the ECR lifecycle policy JSON for the aws_ecr_lifecycle_policy resource.

Relations

Closes #35184

References

Lifecycle policies provides more details on the syntax of the policy JSON.

Output from Acceptance Testing

Note: TestAccECRLifecyclePolicy_detectTagPatternListDiff is a new test case.

$ make testacc TESTS=TestAccECRLifecyclePolicy_ PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRLifecyclePolicy_'  -timeout 360m
=== RUN   TestAccECRLifecyclePolicy_basic
=== PAUSE TestAccECRLifecyclePolicy_basic
=== RUN   TestAccECRLifecyclePolicy_ignoreEquivalent
=== PAUSE TestAccECRLifecyclePolicy_ignoreEquivalent
=== RUN   TestAccECRLifecyclePolicy_detectDiff
=== PAUSE TestAccECRLifecyclePolicy_detectDiff
=== RUN   TestAccECRLifecyclePolicy_detectTagPatternListDiff
=== PAUSE TestAccECRLifecyclePolicy_detectTagPatternListDiff
=== CONT  TestAccECRLifecyclePolicy_basic
=== CONT  TestAccECRLifecyclePolicy_detectDiff
=== CONT  TestAccECRLifecyclePolicy_ignoreEquivalent
=== CONT  TestAccECRLifecyclePolicy_detectTagPatternListDiff
--- PASS: TestAccECRLifecyclePolicy_basic (80.98s)
--- PASS: TestAccECRLifecyclePolicy_ignoreEquivalent (101.03s)
--- PASS: TestAccECRLifecyclePolicy_detectDiff (101.06s)
--- PASS: TestAccECRLifecyclePolicy_detectTagPatternListDiff (101.07s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        101.351s
$

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecr Issues and PRs that pertain to the ecr service. and removed size/M Managed by automation to categorize the size of a PR. labels Jan 10, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 10, 2024
@acwwat acwwat force-pushed the b-aws_ecr_lifecycle_policy-tag_pattern_list_change_detection branch from f392018 to 5d90249 Compare January 10, 2024 21:23
@acwwat acwwat changed the title [WIP] fix: Add missing aws_ecr_lifecycle_policy tagPatternList change [WIP] fix: Add missing aws_ecr_lifecycle_policy tagPatternList change detection Jan 10, 2024
@github-actions github-actions bot added the size/M Managed by automation to categorize the size of a PR. label Jan 10, 2024
@acwwat acwwat force-pushed the b-aws_ecr_lifecycle_policy-tag_pattern_list_change_detection branch from 5d90249 to e551dea Compare January 10, 2024 21:26
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 10, 2024
@acwwat acwwat changed the title [WIP] fix: Add missing aws_ecr_lifecycle_policy tagPatternList change detection fix: Add missing aws_ecr_lifecycle_policy tagPatternList change detection Jan 10, 2024
@ewbankkit ewbankkit mentioned this pull request Mar 29, 2024
Merged
@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.
This work has been rolled into #36493.

@ewbankkit ewbankkit closed this pull request by merging all changes into hashicorp:main in 00aaba9 Mar 29, 2024
@github-actions github-actions bot added this to the v5.44.0 milestone Mar 29, 2024
@acwwat acwwat deleted the b-aws_ecr_lifecycle_policy-tag_pattern_list_change_detection branch April 1, 2024 19:35
@Luis-3M
Copy link

Luis-3M commented Apr 5, 2024

🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kostadin-lazarov1 kostadin-lazarov1 kostadin-lazarov1 approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/ecr Issues and PRs that pertain to the ecr service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.44.0
Development

Successfully merging this pull request may close these issues.

[Bug]: ecr/lifecycle_policy: no changes shown for tagPatternList
5 participants
@acwwat @ewbankkit @Luis-3M @kostadin-lazarov1 @justinretzolk